Add option to detect unmapped error #1086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds:
UnmappedError
Reason
The library uses the
UnmarshallingErrorEvent
error in two cases:json.Unmarshal
We want to be able to check what kind of error we got. As a result, we will be able to do the assertion whether we care about this unmarshal error or not. Example snippet:
Currently, we have in logs:
We could do the error string assertion but it's not a good practice, so we want to avoid that.
Implementation
I decided to leave the
UnmarshallingErrorEvent
as it is, but instead changeto typed error. As a result, is not a breaking change.